[WOD] Heirloom legs at guild vendor

[Lordakius]

Heirloom leg armor at guild vendors

BugTracker link:http://tracker.ashran.com/issues/7898
Wowhead link:

        http://www.wowhead.com/item=122251/polished-legplates-of-valor&bonus=0

       http://www.wowhead.com/item=122252/tarnished-leggings-of-destruction&bonus=0

       http://www.wowhead.com/item=122253/mystical-kilt-of-elements&bonus=0

       http://www.wowhead.com/item=122254/stained-shadowcraft-pants&bonus=0

       http://www.wowhead.com/item=122255/preened-wildfeather-leggings&bonus=0

      http://www.wowhead.com/item=122256/tattered-dreadmist-leggings&bonus=0

      http://www.wowhead.com/item=122264/burnished-legplates-of-might&bonus=0

      http://www.wowhead.com/item=127011/pristine-lightforge-legplates&bonus=0

Brought correction: Added leg armor to guild vendors
Code:

INSERT INTO 'npc_vendor' ('entry', 'slot', 'item', 'maxcount', 'incrtime', 'ExtendedCost') VALUES 
('46602','31','122251','0','0','500'),		
('46602','32','122252','0','0','500'),		
('46602','33','122253','0','0','500'),		
('46602','34','122254','0','0','500'),		
('46602','35','122255','0','0','500'),		
('46602','36','122256','0','0','500'),		
('46602','37','122264','0','0','500'),
('46602','38','127011','0','0','500');		

First SQL post. If there is anything wrong just write what and I will redo this script.

- Not sure if 'ExtendedCost' is correct.

Edited January 3, 2016 by Lordakius

[Lordakius]

It seems, ExtendedCost must be 0, since there is no non-monetary way to buy them.

[Hypnos]

Only  Pristine Lightforge Legplates  could be added because the rest need conditions to show in the vendor.

When I have time I will try to add the conditions and so I will accept the patch. For the moment It will stay in standbay. 

Check the conditions here http://www.wowhead.com/npc=46602/shay-pressler

The patch is ok but when you dont add the full loot, its better to do a replace instead of a insert:

REPLACE INTO 'npc_vendor' ('entry', 'slot', 'item', 'maxcount', 'incrtime', 'ExtendedCost') VALUES 
('46602','31','122251','0','0','500'),		
('46602','32','122252','0','0','500'),		
('46602','33','122253','0','0','500'),		
('46602','34','122254','0','0','500'),		
('46602','35','122255','0','0','500'),		
('46602','36','122256','0','0','500'),		
('46602','37','122264','0','0','500'),
('46602','38','127011','0','0','500');	

And if you do the full loot, so its better to you use a delete before of the insert.

Thanks for the patch, I will update this when I have done the rest.

Regards.

[Csabikaa97]

It needs a guild achievment which is bugged, and can't be completed.

[Lordakius]

http://www.wowhead.com/achievement=6626/working-better-as-a-team

This achievement seems to be buggy then. Thanks for the reply anyway

 

And what is about 'ExtendedCost' ? 

as desribed here: npc_vendor template ExtendedCost refers to another db, which controls the non monetary price. In this case it must be '0' then? 

 

PS:I am working on the conditions atm. No need to stress yourself with them. Gonna post them here, too.

Edited January 6, 2016 by Lordakius

[Daxter]

56 minutes ago, Lordakius said:

And what is about 'ExtendedCost' ? 

as desribed here: npc_vendor template ExtendedCost refers to another db, which controls the non monetary price. In this case it must be '0' then?

Jup, Extendecost is only used when the currency for the item is Honor, jp, Vp, armor-tokens, timeless coins,  etc etc

Edited January 6, 2016 by Daxter

[Lordakius]

9 hours ago, Hypnos said:

Only  Pristine Lightforge Legplates  could be added because the rest need conditions to show in the vendor.

anyone knows where to add those conditions? I haven't found them in the item template. https://trinitycore.atlassian.net/wiki/display/tc/item_template#item_template-entry

Edited January 6, 2016 by Lordakius

[Hypnos]

17 hours ago, Lordakius said:

anyone knows where to add those conditions? I haven't found them in the item template. https://trinitycore.atlassian.net/wiki/display/tc/item_template#item_template-entry

The conditions are in this table https://trinitycore.atlassian.net/wiki/display/tc/conditions

And npc_vendor has a field called `condition_id` too to link the condition to the item.

If you know that any achievement, for buying this items, doesnt work skip that condition and i will add the patch withouth that condition/s.

And yes, the extendedcost is 0 in this case.

REPLACE INTO 'npc_vendor' ('entry', 'slot', 'item', 'maxcount', 'incrtime', 'ExtendedCost',`condition_id`) VALUES 

 

Edited January 7, 2016 by Hypnos

[Lordakius]

http://www.wowhead.com/item=127011/pristine-lightforge-legplates since this one has no conditions (you should be able to get this without any achievements see: Shay Pressler)

the only acceptable fix here is :

REPLACE INTO 'npc_vendor' ('entry', 'slot', 'item', 'maxcount', 'incrtime', 'ExtendedCost','condition_id') VALUES

('46602','38','127011','0','0','0','0');		/*http://www.wowhead.com/item=127011/pristine-lightforge-legplates&bonus=0 */	

Before creating the others we would have the achievement http://www.wowhead.com/achievement=6626/working-better-as-a-team to work.

Any ideas how to do that?

 

I have looked over the conditions table but I would have no idea what to write in that column.

*CONDITION_REALM_ACHIEVEMENT = 6626

ConditionValue1: achievement ID from Achievement.dbc

ConditionValue2: always 0

ConditionValue3: always 0

 

I guess, this is the information I need to fill. (6626 = working better as a team_achievement). This must be filled into the condition_id of npc_vendor?

=>

REPLACE INTO 'npc_vendor' ('entry', 'slot', 'item', 'maxcount', 'incrtime', 'ExtendedCost','condition_id') VALUES 

/* need to rework an achievement: http://www.wowhead.com/achievement=6626/working-better-as-a-team */
	('46602','31','122251','0','0','0','6626'),		
	('46602','32','122252','0','0','0','6626'),		
	('46602','33','122253','0','0','0','6626'),		
	('46602','34','122254','0','0','0','6626'),		
	('46602','35','122255','0','0','0','6626'),		
	('46602','36','122256','0','0','0','6626'),		
	('46602','37','122264','0','0','0','6626'),		

/* working well  */	
('46602','38','127011','0','0','0','0');	

/*links have been removed for better design*/

 

Regards

Lordakius

[Hypnos]

Not really, for condition:

Sourcetypeorreferenceid= 23

conditiontypeorrefenrece = 17

With that values the rest is easy to fill up.

The condition_id isnt the achievement id in npc_vendor. You dont care, i will check the most of Heirloom gear this weekend. And the achievement too.

Thanks you for the patch. It will be accepted when the rest is done like i said before ^^ .

Regards.

[Lordakius]

Okay thank you for explaining

[Hypnos]

Accepted, this monday will be updated guild rewards and guild vendors for 6.2.3. Thanks you for contribuying.

Regards.