[Accepted][Legion]: [Legion] Jewelcrafting Questline

[valhro]

Title: [Legion] Jewelcrafting Questline
Bugtracker Link:

https://firestorm-servers.com/fr/report/see_report/50450

Patch Content:

Hi ! 

 

Here is a patch for Jewelcrafting Questline. I posted it on French Forum but I think this is more efficient here. 

 

Corrected Quest : 

1. Facet-nating Friends
2. Truly Outrageous
3. An Eye for Detail
4. Swift Vengeance
5. Making the Cut
6. A Familiar Ring to It
7. Getting the Band Back Together
8. Knocked for a Loop
9. Finishing Touches
10. Raising the Drogbar
11. Bruls Before Jewels
12. Lapidary Lessons
13. Hidden Intentions
14. Come at Me, Brul
15. The Charge Within
16. Mysteries of Nature
17. Eyes of Nashal
18. Jabrul Needs You
19. To Dalaran, With Love
20. Socket to Me

 

Content access : 

- Tiffany's Design

- Jabrul's Design (Only if questchain completed)

- Jewelcrafting mini-game

- Achievement  http://wowhead.com/achievement=10587/

 

SQL PATCH (>900 lines so I put it on pastebin): 

https://pastebin.com/gjRSHySJ

 

C++ PATCH :

class scene_jewelcrafting_game : public SceneScript
{
    public:
        scene_jewelcrafting_game() : SceneScript("scene_jewelcrafting_game") { }

    // Called when a player receive trigger from scene
    void OnSceneTriggerEvent(Player* player, uint32 /*sceneInstanceID*/, SceneTemplate const* /*sceneTemplate*/, std::string const& triggerName) override
    {
		if(player)
			if (triggerName == "achievement")
				player->CompletedAchievement(10587);// Jewel crafting Achievement (HOT SWAPPER)
    }
};

 

 

SCREENSHOT (French texts because of locales but they are in english in my SQL)

 

 

[zerokzerok]

Astonishing work, i hope they implement this patch

[Elliot]

Already fixed